refactor(Scheduler): rename _updateAppointment and _getUpdatedData#32827
Closed
aleksei-semikozov wants to merge 6 commits intoDevExpress:26_1from
Closed
refactor(Scheduler): rename _updateAppointment and _getUpdatedData#32827aleksei-semikozov wants to merge 6 commits intoDevExpress:26_1from
aleksei-semikozov wants to merge 6 commits intoDevExpress:26_1from
Conversation
…th private access modifiers
…scheduler.ts - _appointmentPopup → appointmentPopup - _appointmentTooltip → appointmentTooltip - _workSpaceRecalculation → workSpaceRecalculation - _header → header - _reloadDataSource → reloadDataSource - _refreshWorkSpace → refreshWorkSpace - _setRemoteFilterIfNeeded → setRemoteFilterIfNeeded - _renderWorkSpace → renderWorkSpace
…enames - helpers.js: _appointmentPopup → appointmentPopup - integration.dateNavigator.tests.js: update assert message for setRemoteFilterIfNeeded - common.options.tests.js: update assert message for reloadDataSource
…ests - common.methods.tests.js: _editAppointmentData → editAppointmentData - common.options.tests.js: _createAppointmentPopupForm → createAppointmentPopupForm
- m_scheduler.ts: _updateAppointment → updateAppointmentCore (conflicts with public updateAppointment) - m_scheduler.ts: _getUpdatedData → getUpdatedData - m_subscribes.ts: update all 4 calls - appointment.editing.tests.js: update 4 monkey-patch usages - integration.appointmentTooltip.tests.js: update sinon.stub call - common.methods.tests.js: update direct call and test name
sjbur
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review comments from sjbur on PR #32811.
Changes
_updateAppointment→updateAppointmentCoreinm_scheduler.ts(note:updateAppointmentis already a public API method)_getUpdatedData→getUpdatedDatainm_scheduler.tsm_subscribes.tsappointment.editing.tests.jssinon.stubcall inintegration.appointmentTooltip.tests.jscommon.methods.tests.jsRelated
Part of #32811 (3518-scheduler-core-replace-underscore-v2)